🐛 | Fix SonarQube violations - use items() and remove assert True

gui.py

@@ -170,8 +170,7 @@ def _load_thumbnail(video_id: str, thumb_url: str,
 
     def _on_downloaded(reply=reply, cache_path=cache_path,
                           art_label=art_label, size=size,
-                          style_pass=style_pass, style_fail=style_fail,
-                          video_id=video_id):
+                          style_pass=style_pass, style_fail=style_fail):
         # The label may have been deleted (e.g. search results refreshed)
         # while the network request was in flight — guard against that.
         try:

tests/conftest.py

@@ -144,11 +144,11 @@ def _install_stubs() -> None:
         (MOD_QTWIDGETS, "QSizePolicy"): _stub("QSizePolicy"),
     }
 
-    for mod_name, attr_name in _PYSIDE_STUBS:
+    for (mod_name, attr_name), stub_value in _PYSIDE_STUBS.items():
         if mod_name not in sys.modules:
             mod = mock.MagicMock(__name__=mod_name.rsplit(".", 1)[-1])
             sys.modules[mod_name] = mod
-        setattr(sys.modules[mod_name], attr_name, _PYSIDE_STUBS[(mod_name, attr_name)])
+        setattr(sys.modules[mod_name], attr_name, stub_value)
 
     # ── yt-dlp ─────────────────────────────────────────────────────────
     if "yt_dlp" not in sys.modules:

tests/test_discord_rpc.py

@@ -230,7 +230,6 @@ class TestDiscordRPC:
         drpc._start_ts = 1000
         # Should not crash
         drpc._send_presence()
-        assert True
 
     def test_connect_oserror_handled(self):
         """_connect handles OSError gracefully (covers lines 119-122)."""

tests/test_player_helpers.py

@@ -301,13 +301,11 @@ class TestCleanupPath:
         """_cleanup_path does nothing for non-existent paths."""
         fn = self._import()
         fn("/nonexistent/path/file.txt")  # should not raise
-        assert True
 
     def test_noop_for_none(self):
         """_cleanup_path does nothing when path is None."""
         fn = self._import()
         fn(None)
-        assert True
 
     def test_oserror_handled_gracefully(self, tmp_path, monkeypatch):
         """_cleanup_path handles OSError gracefully."""
@@ -320,7 +318,6 @@ class TestCleanupPath:
 
         monkeypatch.setattr(os, "unlink", _fail_unlink)
         fn(str(path))  # should not raise
-        assert True
 
 
 # ── _tmp_dir ───────────────────────────────────────────────────────────────────